[PATCH] D43077: [ThinLTO] Import globals

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 14 08:39:50 PST 2018


tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

LGTM with a request for a comment below.



================
Comment at: lib/Transforms/IPO/FunctionImport.cpp:259
+          !GlobalValue::isInterposableLinkage(RefSummary->linkage()) &&
+          RefSummary->refs().empty()) {
+        ImportList[RefSummary->modulePath()][VI.getGUID()] = 1;
----------------
Please add comment about why the restriction on having no outgoing refs.


https://reviews.llvm.org/D43077





More information about the llvm-commits mailing list