[PATCH] D43278: Add Xray instrumentation support to FreeBSD

Kuba (Brecka) Mracek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 14 08:35:37 PST 2018


kubamracek added a comment.

The change looks good to me. In the long term, can we split out the platform-specific logic into separate files, like ASan and TSan is doing, e.g. `asan_linux.cc`, `asan_mac.cc`, etc.? `#ifdef`s are not really scalable.


https://reviews.llvm.org/D43278





More information about the llvm-commits mailing list