[PATCH] D43147: [WebAssembly] Add first class symbol table to wasm objects

[Nicholas Wilson via Phabricator via llvm-commits]

ncw accepted this revision.
ncw added a comment.

No extra feedback from me!



================
Comment at: include/llvm/BinaryFormat/Wasm.h:259
 
+const unsigned WASM_SYMBOL_UNDEFINED          = 0x100;
+
----------------
sbc100 wrote:
> ncw wrote:
> > Should this be renumbered down to 0x8 or 0x10, to use the next available bit, now that it's written out?
> I thought maybe it would be good idea to leave gap in case we want another bit for WASM_SYMBOL_VISIBILITY_MASK... but maybe in that case we should have make the existing masks bigger to start with. 
> 
> Should I add an extra bit to BINDING_MASK and VISIBILITY_MASK for future use?  Maybe no need?
No preference. Using 0xc for VISIBILITY_MASK and then putting UNDEFINED at 0x10 would make sense to me, or renumbering them all to have four bits. Don't mind.


Repository:
  rL LLVM

https://reviews.llvm.org/D43147