[PATCH] D43278: Add Xray instrumentation support to FreeBSD
David CARLIER via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 14 02:39:14 PST 2018
devnexen added a comment.
In https://reviews.llvm.org/D43278#1007192, @dberris wrote:
> LGTM
Thanks.
> Notice to @nglevin who's going to be working on porting to macOS, so that these ifdef's for x86_64 get noticed. I suspect for now this works just fine as we can clean this up later.
>
> Curiously though, do you know why 7 tests are unsupported? Could it be that we're just requiring Linux unnecessarily in those cases?
Good question I enabled FreeBSD for the test and does not see any unsupported tests for FreeBSD but for couple of architectures (anyway I enable only on x86_64 for FreeBSD).
https://reviews.llvm.org/D43278
More information about the llvm-commits
mailing list