[PATCH] D43265: [lit] Fix a problem with spaces in the python path by adding quotes around it

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 13 15:58:18 PST 2018


zturner added a comment.

I wonder if it would be worth fixing this in lit?  Seems like each substitution should be inherently quoted.  Do you know where in lit this is actually failing?  I only bring this up because this is the second such bug you've fixed of this nature, so if it's a recurring problem then we should perhaps fix it at the source.  For example, what if `%clang` also has spaces in the path?  Will that also fail?


Repository:
  rL LLVM

https://reviews.llvm.org/D43265





More information about the llvm-commits mailing list