[PATCH] D43217: [LLD] Implement /guard:[no]longjmp

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lld/COFF/Config.h:75
 
+enum class GuardCFLevel : uint8_t {
+  Off = 0,
----------------
I don't think you need `uint8_t` anymore because you are not using these enum values as integers.


================
Comment at: lld/COFF/Config.h:76-78
+  Off = 0,
+  NoLongJmp = 1, // Emit gfids but no longjmp tables
+  Full = 2,      // Enable all protections.
----------------
I'd remove `= 0`, `= 1` and `= 2` because they are not compared by < nor >.


https://reviews.llvm.org/D43217