[PATCH] D43156: Allow disabling PDB generation in Release build

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

I don't think we should enable PDBs in release mode by default. One of the main uses cases for building in release mode (without PDBs) is to speed up the build. /Zi creates bottlenecks on machines with many cores, and adding /debug to the final link step really hurts incremental build speed.

We've been building LLVM in release mode with PDBs in Chromium for a while now by manually tweaking flags outside the LLVM build system:
https://cs.chromium.org/chromium/src/tools/clang/scripts/update.py?q=update.py+clang&sq=package:chromium&dr=CSs&l=597

If we want to make it easier to profile LLVM, we should add some high level option like `LLVM_ENABLE_PROFILING` and put these flag tweaks under there. Once you have that, then that's a reasonable place to disable ICF.


https://reviews.llvm.org/D43156