[PATCH] D42551: [Debug] Add dbg.value intrinsics for PHIs created during LCSSA.

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 13 09:38:02 PST 2018


vsk added a comment.

In https://reviews.llvm.org/D42551#1006350, @mattd wrote:

> Ping.  Is there anything else we need to do here?  I think the remaining approval was due to the original patch being rejected because it did not cover the catch/landing pads, prior to using the getFirstInsertionPt().


I'm not sure I follow, but the update of this patch from 02/06 looked good to me. To be safe I'll test this out with a stage2 build locally and report back.


https://reviews.llvm.org/D42551





More information about the llvm-commits mailing list