[PATCH] D42848: Correct dwarf unwind information in function epilogue

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 13 09:00:15 PST 2018


aprantl added inline comments.


================
Comment at: lib/CodeGen/BranchFolding.cpp:300
+///  Whether MI should be counted as an instruction when calculating common tail.
+static bool countsAsInstruction(const MachineInstr &MI) {
+  return !(MI.isDebugValue() || MI.isCFIInstruction());
----------------
This should probably be `!isMetaInstruction()`?


================
Comment at: lib/CodeGen/BranchFolding.cpp:370
     --I1;
     while (I1->isDebugValue()) {
       if (I1 == MBB1->begin())
----------------
this too?


Repository:
  rL LLVM

https://reviews.llvm.org/D42848





More information about the llvm-commits mailing list