[PATCH] D43199: [IRMover] Implement name based structure type mapping

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 13 07:56:07 PST 2018


Teresa Johnson <tejohnson at google.com> writes:

> On Tue, Feb 13, 2018 at 7:00 AM, Rafael Avila de Espindola <
> rafael.espindola at gmail.com> wrote:
>
>> Why do you want this?
>>
>> The name of LLVM types should not be important. The cases that we
>> already have are a hack and I think the agreed direction is to have a
>> single pointer type. That would make the type graph a DAG which is
>> trivial to merge.
>>
>
> Hi Rafael,
>
> See his explanation in the reply on https://reviews.llvm.org/D43077 from
> early yesterday. It is leaving bitcasts that are blocking optimization.

This is very similar issue for why we have name handling in the IR mover
at the moment.

It is somewhat scary to add more name specific logic.

David, what is the status on having opaque pointer types?

Cheers,
Rafael


More information about the llvm-commits mailing list