[PATCH] D42611: [ThinLTO/CFI] Include TYPE_ID summaries into GLOBALVAL_SUMMARY_BLOCK

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: clang/test/CodeGen/thinlto-distributed-cfi-devirt.cpp:7
+
+// RUN: %clang_cc1 -triple x86_64-grtev4-linux-gnu -emit-llvm-bc \
+// RUN:   -flto=thin -flto-unit -fvisibility hidden \
----------------
pcc wrote:
> I wonder whether you can simplify this test by making this a `.ll` file and using `opt -thinlto-bc` to create the `.o` file.
I tried tried that from beginning but failed.
Simple dump of %t.o after passing to -thinlto-bc does not produces similar <TYPE_ID> in summaries



================
Comment at: clang/test/CodeGen/thinlto-distributed-cfi-devirt.cpp:72
+// Ensure that linking works.
+// RUN: %clangxx %t.native.o %t2.index.0 -o %t
+
----------------
pcc wrote:
> I think this will only work on Linux. Same goes for your other tests.
Would you prefer if I just remove linking or limit test to linux?


https://reviews.llvm.org/D42611