[PATCH] D42267: [ThinLTO] Allow 0 to be a valid value for pruning interval for C LTO API.
Peter Collingbourne via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 12 16:07:24 PST 2018
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM with a few spelling/grammar nits
================
Comment at: include/llvm-c/lto.h:787
* pruning. An unspecified default value will be applied, and a value of 0 will
- * be ignored.
+ * be force prunning to occur.
*
----------------
nit: remove "be".
================
Comment at: include/llvm/LTO/legacy/ThinLTOCodeGenerator.h:134
* will try to scan the cache directory to prune it from expired entries.
- * Setting to -1 disable the pruning (default).
+ * Setting to -1 disable the pruning (default). Setting to 0 force pruning
+ * to occur.
----------------
nit: "Setting to 0 will force..."
================
Comment at: include/llvm/LTO/legacy/ThinLTOCodeGenerator.h:153
/// Cache policy: interval (seconds) between two prunes of the cache. Set to a
- /// negative value to disable pruning. A value of 0 will be ignored.
+ /// negative value to disable pruning. A value of 0 will force prunning to
+ /// occur.
----------------
nit: prunning -> pruning
Repository:
rL LLVM
https://reviews.llvm.org/D42267
More information about the llvm-commits
mailing list