[PATCH] D43160: [InstSimplify] allow exp/log simplifications with only 'reassoc' FMF

Warren Ristow via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 12 14:26:31 PST 2018


wristow added inline comments.


================
Comment at: test/Transforms/InstSimplify/exp-intrinsic.ll:22
 ;
   %1 = call fast double @llvm.log.f64(double %a)
+  %2 = call reassoc double @llvm.exp.f64(double %1)
----------------
spatel wrote:
> wristow wrote:
> > 'reassoc' instead of 'fast' should also be all that's needed for the llvm.log.f64 call to enable this transformation.
> Hmm...looking a bit closer, this test doesn't add much value. We show that the FMF on the first instruction is irrelevant in the next test (and the same is true in each file). Should I just delete this and its siblings?
Now that you mention it, yes, that makes more sense.


https://reviews.llvm.org/D43160





More information about the llvm-commits mailing list