[llvm] r324947 - [x86] add select test to show there's no single right answer (PR28968); NFC

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 12 14:19:24 PST 2018


Author: spatel
Date: Mon Feb 12 14:19:24 2018
New Revision: 324947

URL: http://llvm.org/viewvc/llvm-project?rev=324947&view=rev
Log:
[x86] add select test to show there's no single right answer (PR28968); NFC

Added:
    llvm/trunk/test/CodeGen/X86/select-1-or-neg1.ll

Added: llvm/trunk/test/CodeGen/X86/select-1-or-neg1.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/select-1-or-neg1.ll?rev=324947&view=auto
==============================================================================
--- llvm/trunk/test/CodeGen/X86/select-1-or-neg1.ll (added)
+++ llvm/trunk/test/CodeGen/X86/select-1-or-neg1.ll Mon Feb 12 14:19:24 2018
@@ -0,0 +1,29 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown                      | FileCheck %s --check-prefix=BASE
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=slow-3ops-lea | FileCheck %s --check-prefix=SLOWLEA3
+
+; TODO: Should the 'cmpl' be 'dec' instead?
+; TODO: What if 'cmov' is 1 uop and full throughput (Ryzen)?
+
+define i32 @PR28968(i32 %x) {
+; BASE-LABEL: PR28968:
+; BASE:       # %bb.0:
+; BASE-NEXT:    xorl %eax, %eax
+; BASE-NEXT:    cmpl $1, %edi
+; BASE-NEXT:    sete %al
+; BASE-NEXT:    leal -1(%rax,%rax), %eax
+; BASE-NEXT:    retq
+;
+; SLOWLEA3-LABEL: PR28968:
+; SLOWLEA3:       # %bb.0:
+; SLOWLEA3-NEXT:    xorl %eax, %eax
+; SLOWLEA3-NEXT:    cmpl $1, %edi
+; SLOWLEA3-NEXT:    sete %al
+; SLOWLEA3-NEXT:    leal (%rax,%rax), %eax
+; SLOWLEA3-NEXT:    addl $-1, %eax
+; SLOWLEA3-NEXT:    retq
+  %cmp = icmp eq i32 %x, 1
+  %sel = select i1 %cmp, i32 1, i32 -1
+  ret i32 %sel
+}
+




More information about the llvm-commits mailing list