[PATCH] D42846: [PartialInlining] Use isInlineViable to detect constructs preventing inlining.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 12 12:51:37 PST 2018


fhahn added a comment.

In https://reviews.llvm.org/D42846#1005429, @efriedma wrote:

> isInlineViable doesn't care whether the code is actually reachable, so you could pessimize partial inlining in certain cases, e.g. a function which calls va_start conditionally.  I don't think we need fix that now, but it would be nice to at least have a testcase demonstrating the issue.


Thanks Eli, I will try to come up with a test case tomorrow.


https://reviews.llvm.org/D42846





More information about the llvm-commits mailing list