[PATCH] D43205: [WebAssembly] Fix casting MCSymbol to MCSymbolWasm on ELF
Derek Schuff via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 12 12:17:14 PST 2018
dschuff added inline comments.
================
Comment at: lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp:94
.getValueAsString();
- getTargetStreamer()->emitImportModule(Sym, Name);
+ getTargetStreamer()->emitImportModule(WasmSym, Name);
}
----------------
Does emitImportModule do anything for ELF? I assume not, maybe it makes more sense to just explicitly condition this whole thing on `BinFormatWasm` and that way when we remove ELF it will be easy to find all the mentions of BinFormatELF or BinFormatWasm in the backend and remove them.
Repository:
rL LLVM
https://reviews.llvm.org/D43205
More information about the llvm-commits
mailing list