[PATCH] D43168: Don't use -ldl on BSD

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 12 10:03:20 PST 2018


MatzeB added a comment.

In https://reviews.llvm.org/D43168#1005292, @krytarowski wrote:

> For such options there are designed other options, like `CMAKE_EXE_LINKER_FLAGS`. `target_link_libraries()` should be used for libraries.


Well the `target_link_libraries()` docu says "Specify libraries or flags to use when linking a given target." and there is no `target_exe_linker_flags()` for that matter. Also at least in principle instead of `EXE_` we would need the `STATIC_`, `SHARED_` variant in some cases.

I'm certainly not proud of how the test-suite uses cmake and am happy to accept patches as long as they work.


Repository:
  rL LLVM

https://reviews.llvm.org/D43168





More information about the llvm-commits mailing list