[PATCH] D42784: [ARM] Allow Half types in ConstantPool

[Oliver Stannard via Phabricator via llvm-commits]

olista01 added inline comments.


================
Comment at: test/CodeGen/ARM/fp16-litpool.ll:47
+; CHECK-ARM:      .LCPI0_{{.}}:
+; CHECK-ARM:        .long LL
+; CHECK-ARM:        .p2align  2
----------------
There are more literal pools here than needed for the test, because the addresses of the globals are materialised as literal pools too. Could this be simplified by passing them in as arguments?

This whole test file is also fragile, as it depends on decisions made by other parts of the backend about whether to use literal pools, and the exact ordering of instructions when we get to the constant pool placement pass. It would be better to convert this to an MIR test to avoid that.


https://reviews.llvm.org/D42784