[PATCH] D43152: [DWARFv5] Turn an assert into a diagnostic.

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

In https://reviews.llvm.org/D43152#1004647, @dblaikie wrote:

> Not sure what you mean by "a non-syscall diagnostic"? (there's StringError if you want to just put a string rather than an error code)


I mean, a case where a std::error_code is not what we want.

> What is it that's undesirable about the error handling you've implemented here? Given that there's a similar error path nearby, that seems like a reasonable (or at least consistent) approach... but I've not looked at this area of the code in detail to see if there's something particularly undesirable about it.

Overloading two return values to indicate an error, instead of a more explicit indication.  And then relying on callers to remember to check for them, instead of forcing callers to check for them.


Repository:
  rL LLVM

https://reviews.llvm.org/D43152