[PATCH] D43188: [ELF] Make .eh_frame relro if one of the inputs is SHF_WRITE

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 12 07:01:28 PST 2018


arichardson added a comment.

In https://reviews.llvm.org/D43188#1005011, @atanasyan wrote:

> As I said in the https://reviews.llvm.org/D43185, probably we need to implement something like `_bfd_elf_eh_frame_section_offset` from BFD library to convert absolute relocations into relative ones and resolve them at the time of linking.


I agree that this is the correct way forward but this at least allows me to create non-broken .so files.

This patch prevents LLD from creating dynamic relocations against a read-only section without `-z notext` so I believe it is a valid bugfix and is independent of a .eh_frame format for MIPS that can be read-only.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D43188





More information about the llvm-commits mailing list