[PATCH] D43125: [ARM] Don't print "Requires NEON" error message for M-profile

Oliver Stannard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 12 05:13:07 PST 2018


olista01 added a comment.

> To have a better handling than this, we'd have to error out earlier saying M-class doesn't have NEON, which probably needs more knowledge than that piece of code has...

We actually could do that here, the code immediately following the change is building the string to be printed, so we could just return a special "M-class doesn't have NEON" string. However, that would probably be a special-case too far, so I think this is fine as it is.


https://reviews.llvm.org/D43125





More information about the llvm-commits mailing list