[PATCH] D43156: Allow disabling PDB generation in Release build

[Takuto Ikuta via Phabricator via llvm-commits]

takuto.ikuta added inline comments.


================
Comment at: cmake/modules/HandleLLVMOptions.cmake:357
   # Generate PDB even in release for profiling.
-  if (uppercase_CMAKE_BUILD_TYPE STREQUAL "RELEASE")
+  option(LLVM_DISABLE_PDB OFF)
+  if (uppercase_CMAKE_BUILD_TYPE STREQUAL "RELEASE" AND NOT LLVM_DISABLE_PDB)
----------------
Can I ask you to use option(LLVM_ENABLE_PDB ON) instead?
I think LLVM_ENABLE_PDB in if condition is easy to understand than NOT LLVM_DISABLE_PDB.


https://reviews.llvm.org/D43156