[llvm] r324806 - [X86] Custom legalize (v2i1 (fp_to_uint/fp_to_sint v2f64)) without AVX512VL.
Craig Topper via llvm-commits
llvm-commits at lists.llvm.org
Sat Feb 10 00:39:31 PST 2018
Author: ctopper
Date: Sat Feb 10 00:39:31 2018
New Revision: 324806
URL: http://llvm.org/viewvc/llvm-project?rev=324806&view=rev
Log:
[X86] Custom legalize (v2i1 (fp_to_uint/fp_to_sint v2f64)) without AVX512VL.
Strangely the code was already present, just the setOperationAction wasn't being called without VLX.
Modified:
llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
llvm/trunk/test/CodeGen/X86/avx512-cvt.ll
Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=324806&r1=324805&r2=324806&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Sat Feb 10 00:39:31 2018
@@ -1168,10 +1168,8 @@ X86TargetLowering::X86TargetLowering(con
setOperationPromotedToType(ISD::FP_TO_UINT, MVT::v8i1, MVT::v8i32);
setOperationPromotedToType(ISD::FP_TO_SINT, MVT::v4i1, MVT::v4i32);
setOperationPromotedToType(ISD::FP_TO_UINT, MVT::v4i1, MVT::v4i32);
- if (Subtarget.hasVLX()) {
- setOperationAction(ISD::FP_TO_SINT, MVT::v2i1, Custom);
- setOperationAction(ISD::FP_TO_UINT, MVT::v2i1, Custom);
- }
+ setOperationAction(ISD::FP_TO_SINT, MVT::v2i1, Custom);
+ setOperationAction(ISD::FP_TO_UINT, MVT::v2i1, Custom);
// Extends of v16i1/v8i1/v4i1/v2i1 to 128-bit vectors.
for (auto VT : { MVT::v16i8, MVT::v8i16, MVT::v4i32, MVT::v2i64 }) {
Modified: llvm/trunk/test/CodeGen/X86/avx512-cvt.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/avx512-cvt.ll?rev=324806&r1=324805&r2=324806&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/X86/avx512-cvt.ll (original)
+++ llvm/trunk/test/CodeGen/X86/avx512-cvt.ll Sat Feb 10 00:39:31 2018
@@ -2234,21 +2234,17 @@ define <2 x double> @ubto2f64(<2 x i32>
}
define <2 x i64> @test_2f64toub(<2 x double> %a, <2 x i64> %passthru) {
-; KNL-LABEL: test_2f64toub:
-; KNL: # %bb.0:
-; KNL-NEXT: # kill: def $xmm1 killed $xmm1 def $zmm1
-; KNL-NEXT: vcvttsd2si %xmm0, %eax
-; KNL-NEXT: andl $1, %eax
-; KNL-NEXT: kmovw %eax, %k0
-; KNL-NEXT: vpermilpd {{.*#+}} xmm0 = xmm0[1,0]
-; KNL-NEXT: vcvttsd2si %xmm0, %eax
-; KNL-NEXT: kmovw %eax, %k1
-; KNL-NEXT: kshiftlw $1, %k1, %k1
-; KNL-NEXT: korw %k1, %k0, %k1
-; KNL-NEXT: vmovdqa64 %zmm1, %zmm0 {%k1} {z}
-; KNL-NEXT: # kill: def $xmm0 killed $xmm0 killed $zmm0
-; KNL-NEXT: vzeroupper
-; KNL-NEXT: retq
+; NOVL-LABEL: test_2f64toub:
+; NOVL: # %bb.0:
+; NOVL-NEXT: # kill: def $xmm1 killed $xmm1 def $zmm1
+; NOVL-NEXT: # kill: def $xmm0 killed $xmm0 def $zmm0
+; NOVL-NEXT: vcvttpd2udq %zmm0, %ymm0
+; NOVL-NEXT: vpslld $31, %ymm0, %ymm0
+; NOVL-NEXT: vptestmd %zmm0, %zmm0, %k1
+; NOVL-NEXT: vmovdqa64 %zmm1, %zmm0 {%k1} {z}
+; NOVL-NEXT: # kill: def $xmm0 killed $xmm0 killed $zmm0
+; NOVL-NEXT: vzeroupper
+; NOVL-NEXT: retq
;
; VL-LABEL: test_2f64toub:
; VL: # %bb.0:
@@ -2257,39 +2253,6 @@ define <2 x i64> @test_2f64toub(<2 x dou
; VL-NEXT: vptestmd %xmm0, %xmm0, %k1
; VL-NEXT: vmovdqa64 %xmm1, %xmm0 {%k1} {z}
; VL-NEXT: retq
-;
-; AVX512DQ-LABEL: test_2f64toub:
-; AVX512DQ: # %bb.0:
-; AVX512DQ-NEXT: # kill: def $xmm1 killed $xmm1 def $zmm1
-; AVX512DQ-NEXT: vpermilpd {{.*#+}} xmm2 = xmm0[1,0]
-; AVX512DQ-NEXT: vcvttsd2si %xmm2, %eax
-; AVX512DQ-NEXT: kmovw %eax, %k0
-; AVX512DQ-NEXT: kshiftlb $1, %k0, %k0
-; AVX512DQ-NEXT: vcvttsd2si %xmm0, %eax
-; AVX512DQ-NEXT: kmovw %eax, %k1
-; AVX512DQ-NEXT: kshiftlb $7, %k1, %k1
-; AVX512DQ-NEXT: kshiftrb $7, %k1, %k1
-; AVX512DQ-NEXT: korb %k0, %k1, %k1
-; AVX512DQ-NEXT: vmovdqa64 %zmm1, %zmm0 {%k1} {z}
-; AVX512DQ-NEXT: # kill: def $xmm0 killed $xmm0 killed $zmm0
-; AVX512DQ-NEXT: vzeroupper
-; AVX512DQ-NEXT: retq
-;
-; AVX512BW-LABEL: test_2f64toub:
-; AVX512BW: # %bb.0:
-; AVX512BW-NEXT: # kill: def $xmm1 killed $xmm1 def $zmm1
-; AVX512BW-NEXT: vcvttsd2si %xmm0, %eax
-; AVX512BW-NEXT: andl $1, %eax
-; AVX512BW-NEXT: kmovw %eax, %k0
-; AVX512BW-NEXT: vpermilpd {{.*#+}} xmm0 = xmm0[1,0]
-; AVX512BW-NEXT: vcvttsd2si %xmm0, %eax
-; AVX512BW-NEXT: kmovd %eax, %k1
-; AVX512BW-NEXT: kshiftlw $1, %k1, %k1
-; AVX512BW-NEXT: korw %k1, %k0, %k1
-; AVX512BW-NEXT: vmovdqa64 %zmm1, %zmm0 {%k1} {z}
-; AVX512BW-NEXT: # kill: def $xmm0 killed $xmm0 killed $zmm0
-; AVX512BW-NEXT: vzeroupper
-; AVX512BW-NEXT: retq
%mask = fptoui <2 x double> %a to <2 x i1>
%select = select <2 x i1> %mask, <2 x i64> %passthru, <2 x i64> zeroinitializer
ret <2 x i64> %select
@@ -2421,21 +2384,16 @@ define <16 x i32> @test_16f32toub(<16 x
}
define <2 x i64> @test_2f64tosb(<2 x double> %a, <2 x i64> %passthru) {
-; KNL-LABEL: test_2f64tosb:
-; KNL: # %bb.0:
-; KNL-NEXT: # kill: def $xmm1 killed $xmm1 def $zmm1
-; KNL-NEXT: vcvttsd2si %xmm0, %eax
-; KNL-NEXT: andl $1, %eax
-; KNL-NEXT: kmovw %eax, %k0
-; KNL-NEXT: vpermilpd {{.*#+}} xmm0 = xmm0[1,0]
-; KNL-NEXT: vcvttsd2si %xmm0, %eax
-; KNL-NEXT: kmovw %eax, %k1
-; KNL-NEXT: kshiftlw $1, %k1, %k1
-; KNL-NEXT: korw %k1, %k0, %k1
-; KNL-NEXT: vmovdqa64 %zmm1, %zmm0 {%k1} {z}
-; KNL-NEXT: # kill: def $xmm0 killed $xmm0 killed $zmm0
-; KNL-NEXT: vzeroupper
-; KNL-NEXT: retq
+; NOVL-LABEL: test_2f64tosb:
+; NOVL: # %bb.0:
+; NOVL-NEXT: # kill: def $xmm1 killed $xmm1 def $zmm1
+; NOVL-NEXT: vcvttpd2dq %xmm0, %xmm0
+; NOVL-NEXT: vpslld $31, %xmm0, %xmm0
+; NOVL-NEXT: vptestmd %zmm0, %zmm0, %k1
+; NOVL-NEXT: vmovdqa64 %zmm1, %zmm0 {%k1} {z}
+; NOVL-NEXT: # kill: def $xmm0 killed $xmm0 killed $zmm0
+; NOVL-NEXT: vzeroupper
+; NOVL-NEXT: retq
;
; VL-LABEL: test_2f64tosb:
; VL: # %bb.0:
@@ -2444,39 +2402,6 @@ define <2 x i64> @test_2f64tosb(<2 x dou
; VL-NEXT: vptestmd %xmm0, %xmm0, %k1
; VL-NEXT: vmovdqa64 %xmm1, %xmm0 {%k1} {z}
; VL-NEXT: retq
-;
-; AVX512DQ-LABEL: test_2f64tosb:
-; AVX512DQ: # %bb.0:
-; AVX512DQ-NEXT: # kill: def $xmm1 killed $xmm1 def $zmm1
-; AVX512DQ-NEXT: vpermilpd {{.*#+}} xmm2 = xmm0[1,0]
-; AVX512DQ-NEXT: vcvttsd2si %xmm2, %eax
-; AVX512DQ-NEXT: kmovw %eax, %k0
-; AVX512DQ-NEXT: kshiftlb $1, %k0, %k0
-; AVX512DQ-NEXT: vcvttsd2si %xmm0, %eax
-; AVX512DQ-NEXT: kmovw %eax, %k1
-; AVX512DQ-NEXT: kshiftlb $7, %k1, %k1
-; AVX512DQ-NEXT: kshiftrb $7, %k1, %k1
-; AVX512DQ-NEXT: korb %k0, %k1, %k1
-; AVX512DQ-NEXT: vmovdqa64 %zmm1, %zmm0 {%k1} {z}
-; AVX512DQ-NEXT: # kill: def $xmm0 killed $xmm0 killed $zmm0
-; AVX512DQ-NEXT: vzeroupper
-; AVX512DQ-NEXT: retq
-;
-; AVX512BW-LABEL: test_2f64tosb:
-; AVX512BW: # %bb.0:
-; AVX512BW-NEXT: # kill: def $xmm1 killed $xmm1 def $zmm1
-; AVX512BW-NEXT: vcvttsd2si %xmm0, %eax
-; AVX512BW-NEXT: andl $1, %eax
-; AVX512BW-NEXT: kmovw %eax, %k0
-; AVX512BW-NEXT: vpermilpd {{.*#+}} xmm0 = xmm0[1,0]
-; AVX512BW-NEXT: vcvttsd2si %xmm0, %eax
-; AVX512BW-NEXT: kmovd %eax, %k1
-; AVX512BW-NEXT: kshiftlw $1, %k1, %k1
-; AVX512BW-NEXT: korw %k1, %k0, %k1
-; AVX512BW-NEXT: vmovdqa64 %zmm1, %zmm0 {%k1} {z}
-; AVX512BW-NEXT: # kill: def $xmm0 killed $xmm0 killed $zmm0
-; AVX512BW-NEXT: vzeroupper
-; AVX512BW-NEXT: retq
%mask = fptosi <2 x double> %a to <2 x i1>
%select = select <2 x i1> %mask, <2 x i64> %passthru, <2 x i64> zeroinitializer
ret <2 x i64> %select
More information about the llvm-commits
mailing list