[PATCH] D43028: Add DBG_VALUE support to the linear DAG scheduler

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 9 19:11:49 PST 2018


probinson added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/ScheduleDAGFast.cpp:797
+          BB->insert(InsertPos, DbgMI);
+        }
+        DVs[i]->setIsInvalidated();
----------------
Don't put braces around a single-line body.
Could compact these 4 lines to 2:
```
if (auto *DbgMI = Emitter.EmitDbgValue(DVs[i], VRBaseMap))
  BB->insert(InsertPos, DbgMI);
```



Repository:
  rL LLVM

https://reviews.llvm.org/D43028





More information about the llvm-commits mailing list