[PATCH] D42937: [DWARF] Make llvm-dwp handle DWARF v5 string offsets tables and indexed strings.
Wolfgang Pieb via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 9 17:42:04 PST 2018
wolfgangp added a comment.
In https://reviews.llvm.org/D42937#1003956, @dblaikie wrote:
> Curious combination of tests - some assembly, some IR. I think I made the existing test cases all checked in binaries.
>
> Perhaps we could come up with a uniform approach/strategy here? (& yeah, I'd probably separate the "testing DWP input" from "testing DWP output" rather than weaving one into the other)
I admit I have a preference for assembly files over checked-in binaries. With checked-in binaries you'd probably have to check in the assembly source as well for reference, and then you have to keep them consistent.
https://reviews.llvm.org/D42937
More information about the llvm-commits
mailing list