[llvm] r324779 - CMake: Allow specifying arbitrary CCACHE parameters

[Matthias Braun via llvm-commits]

Out of interest: Why do we have all this logic in llvms cmake at all?

AFAIK `cmake -DCMAKE_CXX_COMPILER_LAUNCHER=sccache` seems to work just as well...

> On Feb 9, 2018, at 3:25 PM, Justin Bogner via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> Author: bogner
> Date: Fri Feb  9 15:25:23 2018
> New Revision: 324779
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=324779&view=rev
> Log:
> CMake: Allow specifying arbitrary CCACHE parameters
> 
> Introduces the LLVM_CCACHE_PARAMS cmake variable, which can be used to
> pass arbitrary parameters to ccache invocations.
> 
> Modified:
>    llvm/trunk/CMakeLists.txt
> 
> Modified: llvm/trunk/CMakeLists.txt
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/CMakeLists.txt?rev=324779&r1=324778&r2=324779&view=diff
> ==============================================================================
> --- llvm/trunk/CMakeLists.txt (original)
> +++ llvm/trunk/CMakeLists.txt Fri Feb  9 15:25:23 2018
> @@ -144,7 +144,10 @@ if(LLVM_CCACHE_BUILD)
>   if(CCACHE_PROGRAM)
>       set(LLVM_CCACHE_MAXSIZE "" CACHE STRING "Size of ccache")
>       set(LLVM_CCACHE_DIR "" CACHE STRING "Directory to keep ccached data")
> -      set(CCACHE_PROGRAM "CCACHE_CPP2=yes CCACHE_HASHDIR=yes ${CCACHE_PROGRAM}")
> +      set(LLVM_CCACHE_PARAMS "CCACHE_CPP2=yes CCACHE_HASHDIR=yes"
> +          CACHE STRING "Parameters to pass through to ccache")
> +
> +      set(CCACHE_PROGRAM "${LLVM_CCACHE_PARAMS} ${CCACHE_PROGRAM}")
>       if (LLVM_CCACHE_MAXSIZE)
>         set(CCACHE_PROGRAM "CCACHE_MAXSIZE=${LLVM_CCACHE_MAXSIZE} ${CCACHE_PROGRAM}")
>       endif()
> @@ -1022,4 +1025,3 @@ endif()
> if (MSVC AND CMAKE_HOST_SYSTEM_NAME STREQUAL "Windows")
>   include(InstallRequiredSystemLibraries)
> endif()
> -
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits