[PATCH] D43126: [LLD][ELF] Do not error for missing version when symbol has local version.

[Rafael Avila de Espindola via llvm-commits]

Peter Smith via Phabricator <reviews at reviews.llvm.org> writes:
> Index: ELF/Symbols.cpp
> ===================================================================
> --- ELF/Symbols.cpp
> +++ ELF/Symbols.cpp
> @@ -206,8 +206,10 @@
>    // It is an error if the specified version is not defined.
>    // Usually version script is not provided when linking executable,
>    // but we may still want to override a versioned symbol from DSO,
> -  // so we do not report error in this case.
> -  if (Config->Shared)
> +  // so we do not report error in this case. We also do not error
> +  // if the symbol has a local version as it won't be in the dynamic
> +  // symbol table.
> +  if (Config->Shared && VersionId != VER_NDX_LOCAL)

Is the Config->Shared part still required?

Should an error be reported when linking an executable with
--export-dynamic?

Cheers,
Rafael