[PATCH] D42873: [llvm-objcopy] Adjust --strip-dwo behavior

Jake Ehrlich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 9 15:40:32 PST 2018


jakehehrlich added inline comments.


================
Comment at: test/tools/llvm-objcopy/strip-dwo-inplace.test:6
+CHECK:     SectionHeaderCount: 24
+
+CHECK:    Name: .text
----------------
compnerd wrote:
> Might be better to write this test as:
> 
>   CHECK: SectionHeaderCount: 24
>   CHECK-NOT: Name: [[.*]]dwo
I actually prefer this as it verifies a) that all dwo sections were removed and that b) no sections that weren't supposed to be removed were removed. Where as your proposed test only verifies that the dwo sections were removed. 


Repository:
  rL LLVM

https://reviews.llvm.org/D42873





More information about the llvm-commits mailing list