[PATCH] D42873: [llvm-objcopy] Adjust --strip-dwo behavior
Jake Ehrlich via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 9 15:27:38 PST 2018
jakehehrlich accepted this revision.
jakehehrlich added a comment.
One nit and then this LGTM
================
Comment at: tools/llvm-objcopy/llvm-objcopy.cpp:75
static cl::opt<std::string> InputFilename(cl::Positional, cl::desc("<input>"));
-static cl::opt<std::string> OutputFilename(cl::Positional, cl::desc("<output>"),
- cl::init("-"));
+static cl::opt<std::string> OutputFilename(cl::Positional, cl::desc("<output>"));
+
----------------
nit: Could you also add the "[ ... ]" brackets so that the help message shows that the output is optional. other than that this LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D42873
More information about the llvm-commits
mailing list