[PATCH] D43117: [zorg] Cleanup unnecessary options for ARM and AArch64 bots

[Renato Golin via Phabricator via llvm-commits]

rengolin added a comment.

All of the thumb/arm changes I think shouldn't be removed. The main thing is that we can know that stage 1 clang can be compiled as arm/thumb and it runs on all the tests without failure.



================
Comment at: buildbot/osuosl/master/config/builders.py:248
                                         "-DLLVM_TARGETS_TO_BUILD='ARM;AArch64'",
-                                        "-DLLVM_LIT_ARGS='-sv -j2'",
                                         "-DLLVM_PARALLEL_LINK_JOBS=2"])},
 
----------------
maxim-kuvyrkov wrote:
> rengolin wrote:
> > You want to keep the -sv as that should very important information about the tests that failed.
> "-sv" are default LLVM_LIT_ARGS set in CMakeLists.txt.
Ah,must be a new thing, then. :)


================
Comment at: buildbot/osuosl/master/config/builders.py:287
                       runTestSuite=True,
                       testsuite_flags=['--cppflags', '-mcpu=cortex-a57',
                                        '--threads=8', '--build-threads=8'],
----------------
maxim-kuvyrkov wrote:
> rengolin wrote:
> > You're not changing it for LNT, better to do that for both.
> > 
> > I'd also try mcup=native instead...
> > You're not changing it for LNT, better to do that for both.
> 
> What do you mean?  There is no aarch64 LNT bot [yet].
> 
> > I'd also try mcup=native instead...
> 
> Yeah, I plan to switch bots (or add extra variants of bots) for -mcpu=native.  That's gonna be a future change.
I meant testsuite (using LNT), if you look at the line above you'll see what I mean. :)


================
Comment at: buildbot/osuosl/master/config/builders.py:998
                         checkout_lld=False,
-                        extra_cmake_args=["-DCMAKE_C_FLAGS='-mcpu=cortex-a15 -mfpu=vfpv3 -marm'",
-                                          "-DCMAKE_CXX_FLAGS='-mcpu=cortex-a15 -mfpu=vfpv3 -marm'",
-                                          "-DCOMPILER_RT_TEST_COMPILER_CFLAGS='-mcpu=cortex-a15 -mfpu=vfpv3 -marm'",
+                        extra_cmake_args=["-DCOMPILER_RT_TEST_COMPILER_CFLAGS='-mcpu=cortex-a15 -mfpu=vfpv3 -marm'",
                                           "-DLLVM_TARGETS_TO_BUILD='ARM;AArch64'",
----------------
maxim-kuvyrkov wrote:
> rengolin wrote:
> > Are the others being set correctly? They weren't when I did this.
> I don't follow:
> "others" == ???
> "They" == ???
> Please elaborate :-) 
Well, you're deleting C_FLAGS & CXX_FLAGS which didn't use to be set from COMPILER_RT_FLAGS. Unless they are, this will make Clang not compile with ARM/Thumb + VFP, which is important to make sure Clang works on both Arm and Thumb when running the tests. The VFP test is a bit bogus because our boards have NEON...


================
Comment at: buildbot/osuosl/master/config/builders.py:1290
          'factory': LibcxxAndAbiBuilder.getLibcxxAndAbiBuilder(
             cmake_extra_opts={'LIBCXXABI_USE_LLVM_UNWINDER': 'ON',
                               'LLVM_PARALLEL_LINK_JOBS': '2'})},
----------------
maxim-kuvyrkov wrote:
> rengolin wrote:
> > why disabling marm/mthumb here?
> This is a single-stage build, so CMAKE_C_FLAGS and CMAKE_CXX_FLAGS are passed only to host compiler.  AFAICT, they do not affect results of libcxx testsuites.
The host compiler will compile libcxx with arm/thumb and therefore generate different library code, no? Same for test code.


Repository:
  rL LLVM

https://reviews.llvm.org/D43117