[PATCH] D43132: Fix DataFlowSanitizer instrumentation pass to take parameter position changes into account for custom functions.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added a reviewer: pcc.
pcc added inline comments.


================
Comment at: lib/Transforms/Instrumentation/DataFlowSanitizer.cpp:243
+  /// of F into the third argument of F', then this map will contain (0->2).
+  const llvm::DenseMap<unsigned, unsigned> ArgumentIndexMapping;
+};
----------------
I think this can just be a `std::vector<unsigned>`.


================
Comment at: lib/Transforms/Instrumentation/DataFlowSanitizer.cpp:251
+    const TransformedFunction& transformed_function,
+    LLVMContext& Ctx, AttributeList call_site_attrs) {
+
----------------
Please use llvm naming conventions (i.e. `CallSiteAttrs` instead of `call_site_attrs`). Also elsewhere.


Repository:
  rL LLVM

https://reviews.llvm.org/D43132