[PATCH] D43080: Adding Msan support to FreeBSD

[David CARLIER via Phabricator via llvm-commits]

devnexen added inline comments.


================
Comment at: lib/msan/CMakeLists.txt:21
 append_rtti_flag(OFF MSAN_RTL_CFLAGS)
-append_list_if(COMPILER_RT_HAS_FPIE_FLAG -fPIE MSAN_RTL_CFLAGS)
+if(NOT CMAKE_SYSTEM_NAME MATCHES "FreeBSD")
+  append_list_if(COMPILER_RT_HAS_FPIE_FLAG -fPIE MSAN_RTL_CFLAGS)
----------------
krytarowski wrote:
> krytarowski wrote:
> > devnexen wrote:
> > > krytarowski wrote:
> > > > Why pie?
> > > I think it is for performance reason PIE had been added ? Unfortunately the binaries does not build under FreeBSD with both PIC and PIE.
> > pie usually has performance overhead
> We embed initial-exec in the code, please audit the ifdefs whether it's added for FreeBSD.
It seems in first glance but maybe I miss a part or two.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D43080