[PATCH] D43097: [WebAssembly] Allow for the creation of user-defined custom sections

Fri Feb 9 09:00:12 PST 2018

sunfish added a comment.

In https://reviews.llvm.org/D43097#1002844, @sbc100 wrote:

> Sorry maybe I'm jumping the gun here because haven't assigned a reviewer yet..

You're good. For LLVM patches, I'm accustomed to posting the patch first, and letting reviewers choose themselves, or in any case figuring it out later.

> Can we have test in test/MC/WebAssembly too?

Added.

================
Comment at: lib/MC/WasmObjectWriter.cpp:992
   SmallVector<WasmDataSegment, 4> DataSegments;
+  std::vector<std::pair<StringRef, const SmallVectorImpl<char>*>>
+      CustomSections;
----------------
sbc100 wrote:
> would ArrayRef<char> ? Or ArrayRef<uint8_t> work better here?
I initially did exactly that, with ArrayRef and uint8_t, however writeBytes takes a SmallVectorImpl<char>.

Repository:
  rL LLVM

https://reviews.llvm.org/D43097