[PATCH] D43100: Do not print out removed ICF sections for -verbose.

[Rafael Avila de Espindola via llvm-commits]

LGTM with the issues James noticed fixed.

Thanks,
Rafael

James Henderson via Phabricator <reviews at reviews.llvm.org> writes:

> jhenderson added a subscriber: gbreynoo.
> jhenderson accepted this revision.
> jhenderson added a comment.
> This revision is now accepted and ready to land.
> Herald added a subscriber: arichardson.
>
> LGTM with some nits.
>
>
>
> ================
> Comment at: lld/test/ELF/icf-absolute.s:5
>  # RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %S/Inputs/icf-absolute.s -o %t2
> -# RUN: ld.lld %t %t2 -o %t3 --icf=all --verbose 2>&1 | FileCheck %s
> +# RUN: ld.lld %t %t2 -o %t3 --icf=all --print-icf-sections 2>&1 | FileCheck %s
>  
> ----------------
> As --print-icf-sections prints to stdout, you can remove the "2>&1" bit of this line.
>
> Same for every other test update, I believe.
>
>
> ================
> Comment at: lld/test/ELF/icf9.s:5
>  # RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t
> -# RUN: ld.lld %t -o %t2 --icf=all --verbose 2>&1 | FileCheck %s
> +# RUN: ld.lld %t -o %t2 --icf=all --verbose --print-icf-sections 2>&1 | FileCheck %s
>  # RUN: llvm-readelf -S -W %t2 | FileCheck --check-prefix=SEC %s
> ----------------
> Do we need --verbose here still?
>
>
> ================
> Comment at: lld/test/ELF/icf9.s:14-15
>  # We do merge rodata if passed --icf-data
> -# RUN: ld.lld %t -o %t2 --icf=all --verbose --ignore-data-address-equality 2>&1 | FileCheck --check-prefix=DATA %s
> +# RUN: ld.lld %t -o %t2 --icf=all --print-icf-sections --ignore-data-address-equality 2>&1 \
> +# RUN:   | FileCheck --check-prefix=DATA %s
>  # RUN: llvm-readelf -S -W %t2 | FileCheck --check-prefix=DATA-SEC %s
> ----------------
> Very anecdotal this (I haven't looked heavily), and I don't mind this staying the way it is, but it seems more common to do "| \" for line continuations in lit.
>
>
> https://reviews.llvm.org/D43100