[PATCH] D42050: Intercept tzset in MSan on NetBSD

[David CARLIER via Phabricator via llvm-commits]

devnexen added inline comments.


================
Comment at: lib/msan/msan_interceptors.cc:1142
+INTERCEPTOR(void, tzset, void) {
   ENSURE_MSAN_INITED();
+  // Required for NetBSD, as there might be reloaded internal structs and we
----------------
eugenis wrote:
> krytarowski wrote:
> > eugenis wrote:
> > > krytarowski wrote:
> > > > vitalybuka wrote:
> > > > > Any idea why we had "int fake" there?
> > > > It looks like a bug, maybe @eugenis can share more insight.
> > > That's to suppress compiler warnings about vararg macros with no arguments, or something like that.
> > I'm not observing warnings locally. Unless I miss something, calling a function with fake arguments breaks ABI constraints (but it's tolerable in this particular case on x86_64).
> try search code history. Could have been GCC.
Just to add a point, it helps to solves an issue in my pending request, in FreeBSD we really need to have the correct signature.


Repository:
  rL LLVM

https://reviews.llvm.org/D42050