[PATCH] D43043: [DebugInfo] Unify ChecksumKind and Checksum value in DIFile

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

Thanks Scott! This LGTM, but let's wait for @aprantl to have another look before merging this.



================
Comment at: include/llvm/IR/DebugInfoMetadata.h:504
   // file.
   enum ChecksumKind {
+    // The first variant was originally CSK_None, encoded as 0. The new
----------------
scott.linder wrote:
> JDevlieghere wrote:
> > Why did you not choose to make this part of the `ChecksumInfo` struct?
> They do not depend on the template parameter, so this saves having two instances of `ChecksumKind` in the typesystem, namely `ChecksumInfo<MDString *>::ChecksumKind` and `ChecksumInfo<StringRef>::ChecksumKind`.
Makes sense, thanks!


https://reviews.llvm.org/D43043