[PATCH] D43080: Addind Msan support to FreeBSD

[David CARLIER via Phabricator via llvm-commits]

devnexen added inline comments.


================
Comment at: test/msan/tzset.cc:2
 // RUN: %clangxx_msan -O0 %s -o %t && %run %t
+// UNSUPPORTED: freebsd
 
----------------
krytarowski wrote:
> devnexen wrote:
> > krytarowski wrote:
> > > devnexen wrote:
> > > > krytarowski wrote:
> > > > > Why unsupported?
> > > > Those are not set in FreeBSD thus giving segfaults.
> > > What does it mean in detail? tzset() under MSan emits SIGSEGV?
> > > 
> > > Broken tests should be marked as XFAIL.
> > Yes indeed the sanitizer emits the message.
> I have a pending patch for tzset() in D42050.. maybe it helps?
Seems it does fix it indeed. Either I still put it as UNSUPPORTED/XFAIL or making it as SUPPORTED waiting your patch going through first.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D43080