[PATCH] D43097: [WebAssembly] Allow for the creation of user-defined custom sections

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added a comment.

Sorry maybe I'm jumping the gun here because haven't assigned a reviewer yet..

Can we have test in test/MC/WebAssembly too?



================
Comment at: lib/MC/WasmObjectWriter.cpp:992
   SmallVector<WasmDataSegment, 4> DataSegments;
+  std::vector<std::pair<StringRef, const SmallVectorImpl<char>*>>
+      CustomSections;
----------------
would ArrayRef<char> ? Or ArrayRef<uint8_t> work better here?


Repository:
  rL LLVM

https://reviews.llvm.org/D43097