[PATCH] D42495: [WebAssembly] Add symbol table to LLVM, 2/2

[Nicholas Wilson via Phabricator via llvm-commits]

ncw marked an inline comment as done.
ncw added inline comments.


================
Comment at: lib/Object/WasmObjectFile.cpp:460
+      Info.Name = readString(Ptr);
+      if (*Ptr++) {
+        Section = DataSection;
----------------
sbc100 wrote:
> I think we should use readUint8 here.
> 
> I'm also not sure about the use of Optional in WasmSymbolInfo.  I'd rather just explicit this byte directly, like we do with the HAS_MAX flag in WasmLimits.
Done. I was able to re-use the existing DEFINED flag to keep the struct compact


Repository:
  rL LLVM

https://reviews.llvm.org/D42495