[llvm] r324666 - AMDGPU: Minor cleanups

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 8 14:46:38 PST 2018


Author: arsenm
Date: Thu Feb  8 14:46:38 2018
New Revision: 324666

URL: http://llvm.org/viewvc/llvm-project?rev=324666&view=rev
Log:
AMDGPU: Minor cleanups

Column limit, typo, unnecessary reference

Modified:
    llvm/trunk/lib/Target/AMDGPU/SIPeepholeSDWA.cpp
    llvm/trunk/test/CodeGen/AMDGPU/sdwa-peephole.ll

Modified: llvm/trunk/lib/Target/AMDGPU/SIPeepholeSDWA.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AMDGPU/SIPeepholeSDWA.cpp?rev=324666&r1=324665&r2=324666&view=diff
==============================================================================
--- llvm/trunk/lib/Target/AMDGPU/SIPeepholeSDWA.cpp (original)
+++ llvm/trunk/lib/Target/AMDGPU/SIPeepholeSDWA.cpp Thu Feb  8 14:46:38 2018
@@ -218,7 +218,7 @@ FunctionPass *llvm::createSIPeepholeSDWA
 
 
 #if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
-static raw_ostream& operator<<(raw_ostream &OS, const SdwaSel &Sel) {
+static raw_ostream& operator<<(raw_ostream &OS, SdwaSel Sel) {
   switch(Sel) {
   case BYTE_0: OS << "BYTE_0"; break;
   case BYTE_1: OS << "BYTE_1"; break;
@@ -984,7 +984,7 @@ bool SIPeepholeSDWA::convertToSDWA(Machi
     }
   }
 
-  // Apply all sdwa operand pattenrs
+  // Apply all sdwa operand patterns.
   bool Converted = false;
   for (auto &Operand : SDWAOperands) {
     // There should be no intesection between SDWA operands and potential MIs
@@ -1017,7 +1017,8 @@ bool SIPeepholeSDWA::convertToSDWA(Machi
 
 // If an instruction was converted to SDWA it should not have immediates or SGPR
 // operands (allowed one SGPR on GFX9). Copy its scalar operands into VGPRs.
-void SIPeepholeSDWA::legalizeScalarOperands(MachineInstr &MI, const SISubtarget &ST) const {
+void SIPeepholeSDWA::legalizeScalarOperands(MachineInstr &MI,
+                                            const SISubtarget &ST) const {
   const MCInstrDesc &Desc = TII->get(MI.getOpcode());
   unsigned ConstantBusCount = 0;
   for (MachineOperand &Op : MI.explicit_uses()) {

Modified: llvm/trunk/test/CodeGen/AMDGPU/sdwa-peephole.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/AMDGPU/sdwa-peephole.ll?rev=324666&r1=324665&r2=324666&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/AMDGPU/sdwa-peephole.ll (original)
+++ llvm/trunk/test/CodeGen/AMDGPU/sdwa-peephole.ll Thu Feb  8 14:46:38 2018
@@ -498,7 +498,7 @@ entry:
   ret void
 }
 
-; GCN-LABEL: {{^}}sdwa_crash_inlineasm_de
+; GCN-LABEL: {{^}}sdwa_crash_inlineasm_def:
 ; GCN: s_mov_b32 s{{[0-9]+}}, 0xffff
 ; GCN: v_and_b32_e32 v{{[0-9]+}}, s{{[0-9]+}}, v{{[0-9]+}}
 ; GCN: v_or_b32_e32 v{{[0-9]+}}, 0x10000,




More information about the llvm-commits mailing list