[PATCH] D43027: [ThinLTO] Skip BlockAddresses while replacing uses in function import

Dmitry Mikulin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 8 13:10:37 PST 2018


dmikulin marked 2 inline comments as done.
dmikulin added inline comments.


================
Comment at: llvm/test/Transforms/LowerTypeTests/blockaddr-import.ll:1
+; RUN: opt -lowertypetests -lowertypetests-summary-action=import -lowertypetests-read-summary=%p/Inputs/blockaddr-import.yaml %s -o %t.o -O2
+
----------------
dmikulin wrote:
> pcc wrote:
> > I don't think you need `-O2` here.
> I do not need the whole O2 pipeline, but the verifier relies on some analysis passes to set address-taken flags to assert. I changed it to -O1.
Looks like having the check to make sure the new function is used in blockaddress might be sufficient. I'll take out the -O option.


https://reviews.llvm.org/D43027





More information about the llvm-commits mailing list