[PATCH] D43027: [ThinLTO] Skip BlockAddresses while replacing uses in function import

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 8 12:02:00 PST 2018


pcc added inline comments.


================
Comment at: llvm/test/Transforms/LowerTypeTests/blockaddr-import.ll:1
+; RUN: opt -lowertypetests -lowertypetests-summary-action=import -lowertypetests-read-summary=%p/Inputs/blockaddr-import.yaml %s -o %t.o -O2
+
----------------
I don't think you need `-O2` here.


================
Comment at: llvm/test/Transforms/LowerTypeTests/blockaddr-import.ll:29
+n:
+  %call = tail call i32 (i8*, ...) bitcast (i32 (...)* @o to i32 (i8*, ...)*)(i8* blockaddress(@m, %n)) #4
+  ret void
----------------
Please use FileCheck to check that the blockaddress refers to the correct function.


https://reviews.llvm.org/D43027





More information about the llvm-commits mailing list