[PATCH] D43083: [tablegen] Fixed few !foreach evaluation issues.
Artem Belevich via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 8 11:35:06 PST 2018
tra created this revision.
tra added reviewers: craig.topper, jlebar.
Herald added subscribers: hiraditya, sanjoy.
- !foreach on lists didn't evaluate operands of the RHS operator. This made nested operators silently fail.
- A typo in the code could result in a wrong value substituted for an operation which produced a false '!foreach requires an operator' error.
- Keep recursion over the DAG within ForeachHelper. This simplifies things a bit as we no longer need to pass the Type around in order to prevent recursion.
https://reviews.llvm.org/D43083
Files:
llvm/lib/TableGen/Record.cpp
llvm/test/TableGen/foreach-eval.td
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43083.133460.patch
Type: text/x-patch
Size: 7370 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180208/3b5a4d21/attachment.bin>
More information about the llvm-commits
mailing list