[PATCH] D42495: [WebAssembly] Add symbol table to LLVM, 2/2

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: lib/Object/WasmObjectFile.cpp:460
+      Info.Name = readString(Ptr);
+      if (*Ptr++) {
+        Section = DataSection;
----------------
I think we should use readUint8 here.

I'm also not sure about the use of Optional in WasmSymbolInfo.  I'd rather just explicit this byte directly, like we do with the HAS_MAX flag in WasmLimits.


Repository:
  rL LLVM

https://reviews.llvm.org/D42495