[PATCH] D43080: Addind Msan support to FreeBSD

[Kamil Rytarowski via Phabricator via llvm-commits]

krytarowski added inline comments.


================
Comment at: lib/msan/CMakeLists.txt:21
 append_rtti_flag(OFF MSAN_RTL_CFLAGS)
-append_list_if(COMPILER_RT_HAS_FPIE_FLAG -fPIE MSAN_RTL_CFLAGS)
+if(NOT CMAKE_SYSTEM_NAME MATCHES "FreeBSD")
+  append_list_if(COMPILER_RT_HAS_FPIE_FLAG -fPIE MSAN_RTL_CFLAGS)
----------------
devnexen wrote:
> krytarowski wrote:
> > Why pie?
> I think it is for performance reason PIE had been added ? Unfortunately the binaries does not build under FreeBSD with both PIC and PIE.
pie usually has performance overhead


================
Comment at: test/msan/tzset.cc:2
 // RUN: %clangxx_msan -O0 %s -o %t && %run %t
+// UNSUPPORTED: freebsd
 
----------------
devnexen wrote:
> krytarowski wrote:
> > Why unsupported?
> Those are not set in FreeBSD thus giving segfaults.
What does it mean in detail? tzset() under MSan emits SIGSEGV?

Broken tests should be marked as XFAIL.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D43080