[PATCH] D43071: [ELF] - Support DSECT, COPY, INFO, OVERLAY output sections attributes.
Rafael Avila de Espindola via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 8 10:16:32 PST 2018
George Rimar via Phabricator <reviews at reviews.llvm.org> writes:
> + if (consume("DSECT") || consume("COPY") || consume("INFO") ||
> + consume("OVERLAY")) {
> + expect(")");
> + Cmd->Dsect = true;
Please use a more informative name (DontAlloc?) or at least add a
comment to the definition.
Looks like INFO, COPY and OVERLAY are used, so just drop DSECT.
LGTM with that.
Cheers,
Rafael
More information about the llvm-commits
mailing list