[PATCH] D43080: Addind Msan support to FreeBSD

[Kamil Rytarowski via Phabricator via llvm-commits]

krytarowski added a comment.

What are the results of `check-msan`?



================
Comment at: lib/msan/CMakeLists.txt:21
 append_rtti_flag(OFF MSAN_RTL_CFLAGS)
-append_list_if(COMPILER_RT_HAS_FPIE_FLAG -fPIE MSAN_RTL_CFLAGS)
+if(NOT CMAKE_SYSTEM_NAME MATCHES "FreeBSD")
+  append_list_if(COMPILER_RT_HAS_FPIE_FLAG -fPIE MSAN_RTL_CFLAGS)
----------------
Why pie?


================
Comment at: lib/msan/msan.cc:145
     cf.check_printf = false;
+#if !SANITIZER_FREEBSD
     cf.intercept_tls_get_addr = true;
----------------
What's wrong with tls?


================
Comment at: test/msan/textdomain.cc:2
 // RUN: %clangxx_msan -O0 -g %s -o %t && %run %t
+// UNSUPPORTED: freebsd
 
----------------
Why unsupported?


================
Comment at: test/msan/tzset.cc:2
 // RUN: %clangxx_msan -O0 %s -o %t && %run %t
+// UNSUPPORTED: freebsd
 
----------------
Why unsupported?


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D43080