[PATCH] D43064: [LV] Fix analyzeInterleaving when -pass-remarks enabled

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:5929
       // operation as B.
-      if (isInterleaved(A) || A->mayReadFromMemory() != B->mayReadFromMemory())
+      // Note that mayReadFromMemory() isn't mutually exclussive to mayWriteToMemory
+      // in the case of atomic loads. We shouldn't see those here, canVectorizeMemory()
----------------
s/exclussive/exclusive/




================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:5933
+      // remarks.
+      if (isInterleaved(A) || (A->mayReadFromMemory() != B->mayReadFromMemory())
+          || (A->mayWriteToMemory() != B->mayWriteToMemory()))
----------------
Add a test case?


Repository:
  rL LLVM

https://reviews.llvm.org/D43064