[PATCH] D42632: Generate PDB files for profiling even in Release build

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.


================
Comment at: llvm/trunk/cmake/modules/HandleLLVMOptions.cmake:359
+    append("/Zi" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
+    append("/DEBUG" CMAKE_EXE_LINKER_FLAGS CMAKE_MODULE_LINKER_FLAGS CMAKE_SHARED_LINKER_FLAGS)
+  endif (uppercase_CMAKE_BUILD_TYPE STREQUAL "RELEASE")
----------------
Doesn't /DEBUG disable /OPT:REF and /OPT:ICF by default? I think you probably want "/DEBUG /OPT:REF /OPT:ICF" instead of just "/DEBUG".


Repository:
  rL LLVM

https://reviews.llvm.org/D42632