[PATCH] D43067: Implement equal_range for the DWARF v5 accelerator table

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added a comment.

This is very neat, thanks a lot Pavel!

A few insignificant nits inline.



================
Comment at: include/llvm/DebugInfo/DWARF/DWARFAcceleratorTable.h:280
+
+    Entry(const NameIndex &NameInd, const Abbrev &Abbr);
 
----------------
Nit: `Index` is usually `Idx`


================
Comment at: include/llvm/DebugInfo/DWARF/DWARFAcceleratorTable.h:284
+    /// Index or None if this Accelerator Entry does not have an associated
+    /// Compilation Unit. It is up to the user to verify that the returned valid
+    /// in the owning NameIndex (or use getCUOffset(), which will handle that
----------------
... returned Index is valid ...


================
Comment at: include/llvm/DebugInfo/DWARF/DWARFAcceleratorTable.h:303
+    /// .debug_names-specific getter, which always succeeds (DWARF v5 index
+    /// entries always have a tag.
+    dwarf::Tag tag() const { return Abbr->Tag; }
----------------
Missing `)`


Repository:
  rL LLVM

https://reviews.llvm.org/D43067